[framework]:add exist_new_events fun and subscriber_info fun #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx819812523
requested review from
jolestar,
baichuan3 and
wow-sven
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
jolestar
reviewed
Sep 24, 2024
| (subscriber_sequence_number, head_sequence_number, tail_sequence_number) | ||
| } | ||
|
|
||
| public fun exist_new_events<E: copy + drop + store>(subscriber_obj: &Object<Subscriber<E>>): bool { |
baichuan3
reviewed
Sep 24, 2024
|
|
||
|
|
||
|
|
||
| public fun subscriber_info<E: copy + drop + store>(subscriber_obj: &Object<Subscriber<E>>):(u64, u64, u64) { |
There was a problem hiding this comment.
Is it easier to call by passing object_id instead of subscriber_obj ?
There was a problem hiding this comment.
The arguments in the transaction are same, both are ObjectID
There was a problem hiding this comment.
I think there is not much difference between the two
baichuan3
reviewed
Sep 24, 2024
| (subscriber_sequence_number, head_sequence_number, tail_sequence_number) | ||
| } | ||
|
|
||
| public fun exist_new_events<E: copy + drop + store>(subscriber_obj: &Object<Subscriber<E>>): bool { |
|
I merged this and updated it in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary about this PR